On Tue, Jun 2, 2015 at 2:18 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Why? > To have all options required for selecting the capabilities together in one struct. Currently there are independent variables used in a few places for this (fetchpack.c: lines 296 - 309, which is where I also got the formatting from) As soon as I realized I need to touch many places I thought about introducing this struct. But I guess I'll drop this as well as the patches building on top of this because it's actually only fetch-pack.c using it and it would have communicated with the transport layer with this struct. Maybe it is better to let the caller handle each option anyway, so that the transport layer just invokes a callback at the caller (fetchpack or later on sendpack) which immediately decides if it knows the capability and needs to act on it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html