Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> : writes > > +test_expect_success 'drop' ' > > Please, be more descriptive in the first argument of > test_expect_success. It's usually a good thing to say not only what the > test stresses but also what the expected behavior is. > > test_expect_success 'drop actually drops the lines' ' For this one I've based myself on the first argument of some other tests that tests commands for git rebase -i : > t3404-rebase-interactive.sh:240 > test_expect_success 'squash' ' > t3404-rebase-interactive.sh:679 > test_expect_success 'reword' ' Rémi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html