On Fri, May 29, 2015 at 7:05 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Wed, May 27, 2015 at 9:33 AM, Paul Tan <pyokagan@xxxxxxxxx> wrote:
>> @@ -128,13 +190,32 @@ static void am_next(struct am_state *state)
>> */
>> +/**
>> + * parse_options() callback that validates and sets opt->value to the
>> + * PATCH_FORMAT_* enum value corresponding to `arg`.
>> + */
>> +static int parse_opt_patchformat(const struct option *opt, const char *arg, int unset)
>> +{
>> + int *opt_value = opt->value;
>> +
>> + if (!strcmp(arg, "mbox"))
>> + *opt_value = PATCH_FORMAT_MBOX;
>> + else
>> + return -1;
>> + return 0;
>> +}
>> +
>> struct am_state state;
>> +int opt_patch_format;
>
> Should these two variables be static?
Whoops. Yes, they should.
Thanks,
Paul
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html