Remi Lespinet <remi.lespinet@xxxxxxxxxxxxxxxxxxxxxxx> writes:
> Remove the limitation imposed by 79ee555b (Check and document the
> options to prevent mistakes, 2006-06-21) which rejected every argument
> with comma in --cc, --to and --bcc
Missing "." at the end of sentence.
> -The --bcc option must be repeated for each user you want on the bcc list.
> +Addresses containing commas ("Foo, Bar" <foobar@xxxxxxxxxxx>) are not
> +currently supported.
> ++
> +This option may be specified multiple times
Likewise (more instances in the patch).
> +test_expect_success $PREREQ 'setup expected-list' '
> + git send-email \
> + --dry-run \
> + --from="Example <from@xxxxxxxxxxx>" \
> + --to="to1@xxxxxxxxxxx" \
> + --to="to2@xxxxxxxxxxx" \
> + --to="to3@xxxxxxxxxxx" \
> + --cc="cc1@xxxxxxxxxxx" \
> + --cc="Cc 1 <cc1@xxxxxxxxxxx>" \
> + --cc="Cc 2 <cc2@xxxxxxxxxxx>" \
> + --bcc="bcc1@xxxxxxxxxxx" \
> + --bcc="bcc2@xxxxxxxxxxx" \
> + 0001-add-master.patch | replace_variable_fields \
Tab after |. Not really serious, but why not a space?
> + >expected-list
> +'
> +
> +test_expect_success $PREREQ 'use email list in --cc --to and --bcc' '
> + git send-email \
> + --dry-run \
> + --from="Example <from@xxxxxxxxxxx>" \
> + --to="to1@xxxxxxxxxxx, to2@xxxxxxxxxxx" \
> + --to="to3@xxxxxxxxxxx" \
> + --cc="cc1@xxxxxxxxxxx, Cc 1 <cc1@xxxxxxxxxxx>" \
> + --cc="Cc 2 <cc2@xxxxxxxxxxx>" \
> + --bcc="bcc1@xxxxxxxxxxx, bcc2@xxxxxxxxxxx" \
> + 0001-add-master.patch | replace_variable_fields \
> + >actual-list &&
You may drop the space between TAB and >.
I would group the tests: the 'setup' is only used to generate
expected-list which is used only in the second test, so one is not
useful without the other (we commonly have a 'setup ...' test which sets
up something used by several other tests).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html