Re: [RFC/PATCH 0/3] silence missing-link warnings in some cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> Stefan noticed that running "git gc" with a recent version of git causes
> some useless complaints about missing objects.
>
> The reason is that since git d3038d2 (prune: keep objects reachable from
> recent objects, 2014-10-15), we will traverse objects that are not
> reachable but have recent mtimes (within the 2-week prune expiration
> window). Because they are not reachable, we may not actually have all of
> their ancestors; we use the revs->ignore_missing_links option to avoid
> making this a fatal error. But we still print an error message. This
> series suppresses those messages.

Nice finding.  One of us should have thought of this kind of fallout
when we discussed that change, but we apparently failed.

The fixes make sense to me (I haven't carefully read the
implementation, but design/approach explained in the proposed log
messages are very sound), and I think 3/3 is a good thing to do,
too, in the new world order after d3038d2.

Thanks, both.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]