On Fri, May 29, 2015 at 4:17 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> By default, we should run clean-up after the editor we spawned gives
> us the edited result. Not adding one more LF after the template
> when it already ends with LF would not hurt, but an extra blank
> after the template material does not hurt, either, so I am honestly
> indifferent.
I had a similar reaction. The one salient bit I picked up was that
Patryk finds it aesthetically offensive[1] when the template ends with
a comment line, and that comment line does not flow directly into the
comment lines provided by --status. That is:
Template line 1
# Template line 2
# Please enter the commit message...
# with '#' will be ignored...
[1]: Quoting from the commit message of patch 1/2: "...which is very
annoying when template ends with line starting with '#'"
> If the user specified with the --cleanup option not to
> clean-up the result coming back from the editor, then the commented
> material needs to be removed in the editor by the user *anyway*, so
> one more LF would not make that much of a difference in that case,
> either.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html