Remi Lespinet <remi.lespinet@xxxxxxxxxxxxxxxxxxxxxxx> writes: > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -519,6 +519,12 @@ Result: OK > EOF > " > > +replace_variable_fields () { > + sed -e "s/^\(Date:\).*/\1 DATE-STRING/" \ > + -e "s/^\(Message-Id:\).*/\1 MESSAGE-ID-STRING/" \ > + -e "s/^\(X-Mailer:\).*/\1 X-MAILER-STRING/" > +} > + > test_suppression () { > git send-email \ > --dry-run \ > @@ -526,10 +532,7 @@ test_suppression () { > --from="Example <from@xxxxxxxxxxx>" \ > --to=to@xxxxxxxxxxx \ > --smtp-server relay.example.com \ > - $patches | > - sed -e "s/^\(Date:\).*/\1 DATE-STRING/" \ > - -e "s/^\(Message-Id:\).*/\1 MESSAGE-ID-STRING/" \ > - -e "s/^\(X-Mailer:\).*/\1 X-MAILER-STRING/" \ > + $patches | replace_variable_fields \ I wouldn't insist on that, but this change would be better done in a separate, preparatory patch (that would be PATCH 1/2, and the actual code would be PATCH 2/2). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html