On 05/27/2015 09:48 PM, Junio C Hamano wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >> Instead of writing error messages directly to stderr, write them to a >> "strbuf *err". In lock_ref_sha1_basic(), arrange for these errors to >> be returned to its caller. > > I had to scratch my head and view long outside the context before > realizing that the caller lock_ref_sha1_basic() already arranges > with its caller that errors from it are passed via the strbuf, and > this change is just turning verify_lock(), a callee from it, follows > that already established pattern. > > Looks sensible, but the last sentence was misleading at least to me. > > The caller, lock_ref_sha1_basic(), uses this error reporting > convention with all the other callees, and reports its error > this way to its callers. > > perhaps? +1 Thanks for clarifying this sentence. Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html