Fredrik Medley <fredrik.medley@xxxxxxxxx> writes: >>> +#define ALLOW_TIP_SHA1 01 >>> +static int allow_unadvertised_object_request; >> >> It is better to use "unsigned int" for these bit masks, as we are >> not interested in the top-most bit getting special-cased by using a >> signed type. I'll amend this (and the one in upload-pack.c) while >> applying, so no need to resend only to correct these two, unless you >> have other reasons to reroll. > > Sounds like a good idea to change. Please amend it while applying. Alright, will do. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html