On 3/8/07, Junio C Hamano <junkio@xxxxxxx> wrote:
But this is only true if you want to make it really nice. I personally feel that nobody would scream if pushing 1300 refs at once (4K pages and MAX_ARG_PAGES at 32 would give 128K for **argv and its strings, and one ref's worth of data is two 40-digit hex plus refname, roughly 100-byte per ref) is not supported and always failed.
I'm not too worried about linux. It wont have any problems even if you supply megabytes of arguments (if someone will really need such lists, he can increase MAX_ARG_PAGES and be done with it). The proprietary OS' will have the problem, though. And far sooner than 1300 refs (w2k has only 32767 bytes for command line). Besides, don't overestimate peoples readiness to be careful about reference names. I would expect reference names over 100 bytes in length to happen regularly (generated from file names appended with a timestamp, for example). Maybe provide this hooks with simply formatted list on stdin? I.e. <old-ref> <new-ref> <ref-name> LF - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html