Re: [PATCH] git-bundle: Make thin packs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> This commit also changes behaviour slightly: since we now know early 
> enough if a specified ref is _not_ contained in the pack, we can avoid 
> putting that ref into the pack. So, we don't die() here, but warn() 
> instead, and skip that ref.

I am a bit worried about that part.  

If somebody says "bundle create foo.bdl --since=1.day maint" and
maint's tip hasn't changed for a month, we would end up having
no refs and no pack in the bundle with just a warning.

"bundle create foo.bdl -20 master next" does _not_ mean "20 revs
but at least have master and next tip", but it may surprise an
uninitiated to find out that running "bundle list foo.bdl" on
the resulting bundle did not talk about master at all.

I have a feeling that it would avoid confusion if we did not
even start the pack generation and die early when we find the
counting caused us not to include all the positive refs
specified on the command line.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]