On Tue, May 19, 2015 at 5:53 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Yeah, either that, or "insert separator only before adding to
> something else" pattern, i.e.
>
> for (i = 0; i < argc; i++) {
> if (i)
> addch(&msg, ' ');
> addstr(&msg, argv[i]);
> }
>
> Both are easier to read than "always append SP and trim at the end".
> Besides, trimming at the end makes readers wonder if there are cases
> where argv[argc-1] ends with whitespaces and the code on purpose
> removes them.
Yeah, this looks better and is more correct.
Thanks,
Paul
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html