David Aguilar <davvid@xxxxxxxxx> writes: > On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote: >> On Wed, May 20, 2015 at 9:42 AM, David Aguilar <davvid@xxxxxxxxx> wrote: >> >> > + OIFS=$IFS >> > + IFS=' >> > +' >> >> I guess this is just a formatting issue with the mail export as it should read >> >> IFS=$'\n' >> >> Otherwise looks good to me. >> >> -- >> Sebastian Schuberth > > Thanks for the review. > > That's actually a literal newline inside a single-quoted string. > > I'm not sure how portable $'\n' is, but the '<literal-newline>' > approach is used often in the git code. Thanks for being observant ;-) Unless it is contrib/completion that is known to be run with bash, please avoid $'string' and $"string". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html