Junio C Hamano <junkio@xxxxxxx> wrote: > I may not be reading the patch correctly, but doesn't this make > find_deltas() logic to scan the list backwards? We sort the > list by type and size before we enter this, so that we scan from > bigger to smaller, because we prefer to leave biggest as a base > and represent smaller ones as deltas (removing deltas do not > have to record preimage and tend to be much smaller than adding > deltas). I suspect this change may affect that optimization. Its always scanned backwards. I've read the patch like 8 times now (and I just reread the part you quoted). The patch implements the same backwards scan that has always been there. Linus put it backwards for the exact reason you state; bigger objects are near the end of the array (see type_size_sort). -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html