Re: [PATCH] progress: no progress in background

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

>> +static int is_foreground_fd(int fd)
>> +{
>> +	return getpgid(0) == tcgetpgrp(fd);
>> +}
>
> I've noticed that this patch causes a regression when we are
> transmitting progress over the sideband channel of the git protocol.

Yeah, thanks.  The other day when an unrelated progress issues came,
I realized that this patch has that breakage (and immediately forgot
about it ;-).

> ... Whatever the reason, it probably makes sense to err on the
> side of printing the progress.

Yup.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]