Junio C Hamano <gitster@xxxxxxxxx> writes: > If the contents to be cleaned is small enough (i.e. the one-liner > file used in this test) to fit in the pipe buffer and we feed the > pipe before 'true' exits, we won't see any problem. Otherwise we > may get SIGPIPE when we attempt to write to the 'true' (non-)filter, > but because we explicitly ignore SIGPIPE, 'true' still is a "black > hole" filter. > > "cat >/dev/null" may have been a more naive and straight-forward way > to write this "black hole" filter, but what you did is fine. I spoke too fast X-<. "while sh t0021-*.sh; do :; done" dies after a few iterations and with this squashed in it doesn't. t/t0021-conversion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh index 42e6423..b778faf 100755 --- a/t/t0021-conversion.sh +++ b/t/t0021-conversion.sh @@ -218,7 +218,7 @@ test_expect_success "filter: clean empty file" ' ' test_expect_success "filter: smudge empty file" ' - git config filter.empty-in-repo.clean true && + git config filter.empty-in-repo.clean "cat >/dev/null" && git config filter.empty-in-repo.smudge "echo smudged && cat" && echo "empty-in-repo filter=empty-in-repo" >>.gitattributes && -- 2.4.1-374-g090bfc9 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html