On Fri, May 15, 2015 at 4:44 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Sébastien Guimmara <sebastien.guimmara@xxxxxxxxx> writes: >>> You could for example have used the existing "# List of known git >>> commands" as such a signal to tell that all the no comment lines >>> below are commands. >> >> I tend to think that relying on comments as marks for parsers is brittle, >> but indeed square brackets get in the way of sed regexes. I'll think of >> something better. Thanks. > > Heh, we, and more importantly our users, already rely on a marker in > comments when writing their commit log messages ;-) > > I would not be opposed to a new header that is outside comment, but > I do not think the marker line that is also a comment is "brittle" > and would not be opposed to that, either. > > # do not molest the next line > ### command list > # name category > git-add mainporcelain > ... > > would be perfectly acceptable. > > I was just pointing out that you did not even have to have patch > 1/5. Is that entirely accurate? The machinery (Makefiles, cmd-list.perl) does have to be updated at some point to skip the "common" block which get added in patch 2/5. That work could be done as part of patch 2/5, though it seemed cleaner to me to make it separate (though I don't care too strongly). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html