Hi, On Fri, May 15, 2015 at 1:11 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > One advice; for a small patch like this one (and the "pull.ff vs > merge.ff" one, too), it is not necessary or even desirable to do a > two-step "first add a failure test and then another patch to fix and > flip the expectation" series. Just do the fix and add a test to > expect success. > > After all, the primary reason why we add test is *not* for you to > demonstrate that what you did works as expected. It is to catch > other people breaking what you did in the future. Since I will be re-rolling all the patches to remove the use of "verbose" I guess I will squash the patches as well. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html