git pack protocol question: sideband responses in case of errors?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

since a long time I am hitting very seldom errors when pushing with a
jgit client leading to "invalid channel 101" errors on client side. I
was always wondering why it was always the channel "101". Now I found
out with wireshark and it leads me to a question regarding the git
pack protocol [1] and the sideband capability [2] which I couldn't
answer from the technical docs.

This is what happened: A client wants to push over http to a git
server. In the beginning they negotiated to use side-band-64k and
report-status capabilities. Everything works fine, Packfile data
transmission starts and sideband communication is ok. Now the server
hits a severe problem persisting the packfile and wants to stop the
transport. The git server hit's quotas on the filesystem usage and is
not allowed to persist that big file. My git server (I use a modified
gerrit server) intends to send back a packet line "0013error: ...".
But the client when reading that respond still thinks we should use
sideband communication and interpretes the "e" from "error" as
channel. The ascii code of "e" is the solution why it was always
"invalid channel 101"

Here is my question:
- When exactly should sideband communication during a http based push
start and when should it end? Especially in case of an error on the
server side. Is the server allowed to switch to non-sideband
communication under special conditions? E.g. when the server responds
not with 200OK but with 413 (entity too large).
- Is responding with status code 200 mandatory when talking git pack
protocol? Am I allowed as git server to respond with status code 413
and fill the body of the response with the status report?

Ciao
  Chris

[1] https://raw.githubusercontent.com/git/git/master/Documentation/technical/pack-protocol.txt
[2] https://raw.githubusercontent.com/git/git/master/Documentation/technical/protocol-capabilities.txt
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]