On Tue, May 12, 2015 at 1:32 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: > On 05/11/2015 09:37 PM, Junio C Hamano wrote: >> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: >> ... >>> + test_must_fail git update-ref --stdin <input 2>output.err && >>> + grep -F "$error" output.err && >> >> I am not 100% confident that "grep -F" is the right thing to use >> here. I checked all the error message these tests are expecting and >> none seems to go through _(), but is it fundamental that these >> errors should not be translated? > > Aren't tests run in the "C" locale so that tests don't have to worry > about i18n? But there is a i18n markings test, for which test-i18ngrep was invented for. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html