On Sun, 2015-05-10 at 09:06 +0200, Johannes Sixt wrote: > > + ln -s loop2 loop1 && > > + git add . && > > + git commit -am "test" > > +' > > These tests will fail on a file system that does not support symbolic > links, such as on Windows. Would you please separate the test cases > (that come after the setup) into two groups: > > 1. Those that inspect the filesystem and expect a symbolic link. Protect > these tests with a SYMLINKS prerequisite. I believe that none of these require that. > Note that you do not require a symlink enabled file system to generate a > repository with symlinks, i.e., you don't have to protect the setup code > with SYMLINKS. For this, you can use 'test_ln_s_add' instead of the > above sequence of 'ln -s' followed by a single 'git add .'. Will fix, thanks. > > + > > +echo $hello_sha1 blob $hello_size > found > > This seems to be used only in the next test. Please move it inside > test_expect_success. This is used in a number of tests, e.g this one: > > +test_expect_success 'git cat-file --batch-check --follow-symlinks works for in-repo, same-dir links' ' > > + echo HEAD:same-dir-link | git cat-file --batch-check --follow-symlinks > actual && > > + test_cmp found actual > > +' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html