On Sat, May 9, 2015 at 1:17 PM, Sébastien Guimmara
<sebastien.guimmara@xxxxxxxxx> wrote:
> command-list.txt contains a [common] block that should be ignored
> by the Documentation checker cmd-list.perl.
>
> Filter out this block before the actual processing of the command list.
>
> Signed-off-by: Sébastien Guimmara <sebastien.guimmara@xxxxxxxxx>
> ---
> diff --git a/Documentation/cmd-list.perl b/Documentation/cmd-list.perl
> index 04f9977..d581378 100755
> --- a/Documentation/cmd-list.perl
> +++ b/Documentation/cmd-list.perl
> @@ -38,8 +38,14 @@ sub format_one {
> }
> }
>
> +my @filtered = ();
> +while (<>)
> +{
Style: while (<>) {
> + push (@filtered, $_) unless 1../^\[commands\]/;
> +}
Why collect the lines into @filtered when you could instead merely
skip the unwanted ones outright?
while (<>) {
last if /^\[commands\]/;
}
And, then you don't need to touch the following 'for' loop at all.
> my %cmds = ();
> -for (sort <>) {
> +for (sort @filtered) {
> next if /^#/;
>
> chomp;
> --
> 2.4.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html