On Sat, 2015-05-09 at 10:39 -0700, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > dturner@xxxxxxxxxxxxxxxx writes: > > > >> From: David Turner <dturner@xxxxxxxxxxx> > >> > >> Wire up get_sha1_with_context to call get_tree_entry_follow_symlinks > >> when GET_SHA1_FOLLOW_SYMLINKS is passed in flags. G_S_FOLLOW_SYMLINKS > >> is incompatible with G_S_ONLY_TO_DIE because the diagnosis that > >> ONLY_TO_DIE triggers does not consider symlinks. > > > > Is "does not consider" something fundamental, or it just happens to > > be that way right now? > > Regardless of the answer to this question, I find the last part of > this hunk puzzling. You're right -- this code is wrong, for the reasons you explain. I'm going to follow your earlier suggestion and use a strbuf for the new field. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html