Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx> > --- > Makefile | 10 +++++++--- > git-gui/Makefile | 5 ----- > 2 files changed, 7 insertions(+), 8 deletions(-) Nack. You need to split any git-gui changes into their own patch so that I can apply them to the git-gui repository directly. Junio then merges that into git.git. > +QUIET_SUBDIR0 = $(MAKE) -C # space to separate -C and subdir > +QUIET_SUBDIR1 = > + > +ifneq ($(findstring $(MAKEFLAGS),s),s) This is a good idea. > ifndef V > QUIET_CC = @echo ' ' CC $@; > QUIET_AR = @echo ' ' AR $@; > @@ -615,9 +620,8 @@ ifndef V > $(MAKE) --no-print-directory -C $$subdir > export V > export QUIET_GEN > -else > - QUIET_SUBDIR0 = $(MAKE) -C > - QUIET_SUBDIR1 = > + export QUIET_BUILT_IN > +endif > endif > diff --git a/git-gui/Makefile b/git-gui/Makefile > -ifndef V > - QUIET_GEN = @echo ' ' GEN $@; > - QUIET_BUILT_IN = @echo ' ' BUILTIN $@; > -endif > - git-gui can be built on its own, outside of git.git's make system. I need the ifneq(...-s...) thing above also here, around the existing ifndef. Want to rework the patch as two? ;-) -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html