Danny Lin <danny0838@xxxxxxxxx> writes: > cmd_split() prints a CR char by assigning a variable > with a literal CR in the source code, which could be > trimmed or mis-processed in some terminals. Replace > with $(printf '\r') to fix it. > > Signed-off-by: Danny Lin <danny0838@xxxxxxxxx> > --- > contrib/subtree/git-subtree.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh > index fa1a583..3a581fc 100755 > --- a/contrib/subtree/git-subtree.sh > +++ b/contrib/subtree/git-subtree.sh > @@ -596,10 +596,11 @@ cmd_split() > revmax=$(eval "$grl" | wc -l) > revcount=0 > createcount=0 > + CR=$(printf '\r') > eval "$grl" | > while read rev parents; do > revcount=$(($revcount + 1)) > - say -n "$revcount/$revmax ($createcount) > " > + say -n "$revcount/$revmax ($createcount)$CR" Interesting. I would have expected, especially this is a portability-fix change, that the change would be a single liner - say -n ... + printf "%s\r" "$revcount/$revmax ($createcount)" that does not touch any other line. > debug "Processing commit: $rev" > exists=$(cache_get $rev) > if [ -n "$exists" ]; then -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html