On Tue, May 05, 2015 at 03:19:32PM +0200, SZEDER Gábor wrote: > Don't offer the "main" 'git credential' command or any of the credential > helpers from contrib/credential/ when completing git commands. Makes sense to me, modulo the typo Erik pointed out. > I was tempted to simply filter out 'credential-*', so we don't have to > update this list when new credential helpers arrive. However, the > 'git-credential-*' "namespace" is not explicitly reserved for credential > helpers, users have to set the 'credential.helper' config variable to tell > explicitly that 'git-credential-foo' should be used as credential helper, > and who knows, someone might have his own 'git-credential-bar' command that > does something completely unrelated to git's credential system, so in the > end decided against it. And credential helpers don't pop up too frequently > anyway. > > However, if you think filtering out 'credential-*' is the way to go, I'm > happy to reroll. I'd actually be fine with just marking all credential-* as "credentials helper". I think we have staked out the "git-credential-foo" namespace, so anybody putting something unrelated in there deserves what they get. And it makes one fewer list to keep up to date. I _do_ have other git-credential-foo's that should be ignored (and are not in your list), but I am probably the only person in the world (they are due to me experimenting with the credential helper code :) ). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html