On Fri, Apr 24, 2015 at 03:46:30PM -0700, Pete Harlan wrote: > On Fri, Apr 24, 2015 at 3:28 PM, brian m. carlson > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > The git_connect function has code to handle plink and tortoiseplink > > specially, as they require different command line arguments from > > OpenSSH. However, the match was done by checking for "plink" > > case-insensitively in the string, which led to false positives when > > Perhaps s/case-insensitively/anywhere/? > > It's not important that it ignored case (your change ignores it too), > it's that it was too lenient about its context. Yes, I don't know what I was thinking. I'll wait a bit to see if there are any more comments and then reroll. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature