On Wed, Apr 22, 2015 at 10:24:55PM +0000, brian m. carlson wrote: > On Wed, Apr 22, 2015 at 06:00:54PM -0400, Jeff King wrote: > > Yeah, that looks right to me. You might want to represent the "are we > > tortoise" check as a separate flag, though, and reuse it a few lines > > later. > > Sounds like a good idea. I'll send a more formal patch a bit later > today. Thanks. > > Also, not related to your patch, but I notice the "putty" declaration is > > in a different scope than I would have expected, which made me wonder if > > it gets initialized in all code paths. I think is from the recent > > addition of CONNECT_DIAG_URL, which pushes the bulk of the code into its > > own else clause, even though the first part of the "if" always returns > > early. I wonder if it would be simpler to read like: > [...] > > I can drop this in as a preparatory patch if I can have your sign-off. Definitely, thanks. Signed-off-by: Jeff King <peff@xxxxxxxx> -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html