Re: [PATCH 1/3] git-multimail: Add an option to filter on branches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Michael,

The only code I'm not fond of is matching on a list of regular
expressions.  There must be a more pythonic way to do:

+ return [x for x in [r.match(branch) for r in branches] if x]

which basically returns true if "branch" matches any regular
expression in the list.

I pushed this change out to our production git server (its good to be
the king.)  I'll obviously update here if it does anything too
unfortunate.


On Wed, Apr 22, 2015 at 6:39 PM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote:
> On 04/22/2015 01:04 AM, Dave Boutcher wrote:
>> Add a branches option to the config.  Only changes
>> pushed to specified branches will generate emails. Changes to tags
>> will continue to generate emails.
>
> Thanks for the patches. Patches 2 and 3 seem uncontroversial, so I
> already merged them. Patch 1 is more interesting, and there have been
> other proposals for similar features, so I created a pull request for it:
>
>     https://github.com/git-multimail/git-multimail/pull/75
>
> (Note the new URL--I just created a GitHub "organization" for
> git-multimail to make it easier for other people to get involved. More
> info soon...)
>
> Michael
>
> --
> Michael Haggerty
> mhagger@xxxxxxxxxxxx
>



-- 
Dave B
包小龙
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]