Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > >> Elia Pinto <gitter.spiros@xxxxxxxxx> writes: >> >>> --- a/t/test-lib-functions.sh >>> +++ b/t/test-lib-functions.sh >>> @@ -478,7 +478,7 @@ test_external_without_stderr () { >>> test_path_is_file () { >>> if ! test -f "$1" >>> then >>> - echo "File $1 doesn't exist. $*" >>> + echo "File $1 doesn't exist. $2" >>> false >>> fi >>> } >>> @@ -486,7 +486,7 @@ test_path_is_file () { >>> test_path_is_dir () { >>> if ! test -d "$1" >>> then >>> - echo "Directory $1 doesn't exist. $*" >>> + echo "Directory $1 doesn't exist. $2" >>> false >>> fi >>> } >> >> Sounds straightforwardly correct to me. > > Thanks. This however makes me wonder why you were nominated for > reviewing this patch, though... It seems I'm the one who introduced the bug indeed, in 2caf20c52b7f6. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html