On Sat, Apr 18, 2015 at 12:15:28AM +0530, karthik nayak wrote:
> >But now we use type_from_string_gently, which can accept a length[1]. So
> >we could just count the bytes to the first space and pass the original
> >buffer along with that length, no?
>
> Yes, we could, that would eliminate "struct strbuf typename =
> STRBUF_INIT".
>
> Something like this perhaps :
Yeah, this is exactly what I had in mind.
> {
> - char type[10];
> - int i;
> + const char *buf = hdr;
> unsigned long size;
> + int type, len = 0;
Maybe switch the names of "buf" and "len" to "type_buf" and "type_len"
to make their purpose more clear?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html