Johannes Schindelin <johannes.schindelin@xxxxxx> writes:
> On 2015-04-15 20:48, Junio C Hamano wrote:
>
>> The patch should do for now, but I suspect that it may give us a
>> better abstraction to make the "is_foreground_fd(int fd)" or even
>> "is_foreground(void)" the public API that would be implemented as
>>
>> int we_are_in_the_foreground(void)
>> {
>> return getpgid(0) == tcgetpgrp(fileno(stderr));
>> }
>>
>> in POSIX and Windows can implement entirely differently.
> ...
> In general, I find it rewarding not only from a portability point of
> view, but *especially* from a readability one if the code contains
> functions that are named semantically, i.e. they describe *why* they
> are called, not *how* they answer the question.
Yeah, that was the rationale behind the suggestion (i.e. how may be
different depending on the platform, and the main code flow cares
more about why and not how).
I'll queue Luke's patch with J6t's compat/ for now, but if you find
more suitable implementation for the higher-level abstraction,
please do send a follow-up patch to update it.
Two Johannes'es may need to talk between themselves to agree what
the right level of abstraction is, though. I trust two of you a lot
more than my gut feeling when it comes to POSIX vs Windows API
differences ;-)
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html