Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Tue, Apr 14, 2015 at 1:39 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> It is OK to omit the name in the extern declaration here. > > It is OK, but I think this is bad practice. Take a special note on the word "here", meaning "in this particular case." It is perfectly fine when the meaning of the parameter is clear from its type. I was assuming that our developers have common sense to disambiguate ambiguous cases, of course ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html