Max Kirillov <max@xxxxxxxxxx> writes:
Again, just surface nitpicks.
[side: Kirill Smelkov <kirr@xxxxxxxxxx> removed from CC, as the
ddress just bounced for me]
> +static int changed_parents(struct combine_diff_path *p, int n)
> +{
> + int parent_idx;
> + int result = 0;
> +
> + for (parent_idx = 0; parent_idx < n; ++parent_idx) {
> + if (p->parent[parent_idx].status != ' ')
> + ++result;
We write C (not C++) and favor post_increment++ over ++pre_increment
when there is no valid reason to do otherwise (e.g. the result of
increment getting used in a larger expression).
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html