Re: [PATCH] systemd socket activation support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 2, 2015 at 8:47 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
>
>> On Wed, Apr 1, 2015 at 9:23 PM, Shawn Landden <shawn@xxxxxxxxxxxxxxx> wrote:
>>> From: Shawn Landden <shawnlandden@xxxxxxxxx>
>>>
>>> [PATCH] systemd socket activation support
>>
>> This patch feels like an RFC rather than a properly fleshed-out
>> submission. If so, indicate such in the subject. Also, mention the
>> area you're touching, followed by a colon, followed by the summary of
>> the change:
>>
>>     [PATCH/RFC] daemon: add systemd support
>> ...
>
> Everything Eric said ;-)
>
> Another thing is that this must be a build-time conditional.  Not
> all platforms can use systemd in the first place, and some people
> may choose not to use it even if the platform is capable of.
>
> I was somewhat surprised that sd-daemon.c needed to be built on our
> side, not used from systemd support library, as what it did looked
> very common and not specific to our needs. I would have expected to
> see inclusion of "sd-daemon.h" with -lsystemd-daemon or something on
> the command line.
There is a libsystemd, but when we are using so little of it it seems
cleaner to being it to us instead. I can do that in the next patch....
along with build conditional.


-- 
Shawn Landden
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]