Re: [PATCH v2] enter_repo(): fix docs to match code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 31, 2015 at 10:35:56AM -0700, Junio C Hamano wrote:

> > In b3256eb (standardize and improve lookup rules for external local
> > repos), enter_repo() was modified to use a different precedence ordering
> > of suffixes for DWIM of the repository path, and to ensure that the
> > repository path is actually valid instead of just testing for existence.
> > However, the documentation was not modified to reflect these changes.
> > As such, fix the documentation to match the code.
> >
> > Documentation contributed by Jeff King.
> >
> > Signed-off-by: Jeff King <peff@xxxxxxxx>
> > Signed-off-by: Paul Tan <pyokagan@xxxxxxxxx>
> > ---
> 
> It appears to me that Peff's "squash" is nullifying everything you
> did, so a more truthful attribution might be

I'm not sure that's true. The precedence changed, and the "is it valid"
check changed. The fix for the first is from Paul, but the latter is
from me. My squash (hopefully) retained his half. My half just took more
words to change.

I'm OK with the attribution either way (I do not need the credit, but am
happy to take the blame).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]