On Fri, Mar 27, 2015 at 6:32 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > --- > diff --git a/shallow.c b/shallow.c > index d8bf40a..f8b0458 100644 > --- a/shallow.c > +++ b/shallow.c > @@ -416,7 +416,7 @@ static void paint_down(struct paint_info *info, const unsigned char *sha1, > uint32_t *bitmap = paint_alloc(info); > struct commit *c = lookup_commit_reference_gently(sha1, 1); > if (!c) > - return; > + goto out; Rather than slapping on a band-aid, a cleaner fix would be to move the allocation of 'tmp' below this conditional since 'tmp' is never used before the point of this early return. Perhaps also move allocation of 'bitmap' below the early return (if you find that it's safe to do so). > memset(bitmap, 0, bitmap_size); > bitmap[id / 32] |= (1 << (id % 32)); > commit_list_insert(c, &head); > @@ -471,7 +471,7 @@ static void paint_down(struct paint_info *info, const unsigned char *sha1, > if (o && o->type == OBJ_COMMIT) > o->flags &= ~SEEN; > } > - > +out: > free(tmp); > } -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html