On Fri, 27 Mar 2015 at 01:26 Junio C Hamano <gitster@xxxxxxxxx> wrote: >As to 1/2 the lack of esac is clearly a bug---any self respecting >POSIX shell should have executed it without complaining. But >changing from ':' to true should not be necessary---after all, the >colon is a more traditional way to spell true to Bourne shells, and >we use it in many places already. Can you try reverting all the >"colon to true" bits, keeping only the "add missing esac" part, and >run your tests again? I confirm that it still works with ':' instead of true; could swear I tested that at the time... Anyway, I'll re-submit this patch with this fixed tomorrow. Thanks for taking the time to review the patch. One more thing: was there any change in way diff-tree detects copies? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html