On Tue, Mar 24, 2015 at 1:20 AM, Paul Tan <pyokagan@xxxxxxxxx> wrote: > t0302 now tests git-credential-store's support for the XDG user-specific > configuration file $XDG_CONFIG_HOME/git/credentials. Specifically: > > * Ensure that the XDG file is strictly opt-in. It should not be created > by git at all times if it does not exist. > > * Conversely, if the XDG file exists, ~/.git-credentials should > not be created at all times. > > * If both the XDG file and ~/.git-credentials exists, then both files > should be used for credential lookups. However, credentials should > only be written to ~/.git-credentials. > > * Credentials must be erased from both files. > > * $XDG_CONFIG_HOME can be a custom directory set by the user as per the > XDG base directory specification. Test that git-credential-store > respects that, but defaults to "~/.config/git/credentials" if it does > not exist or is empty. > > Helped-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> > Helped-by: Junio C Hamano <gitster@xxxxxxxxx> > Helped-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > Signed-off-by: Paul Tan <pyokagan@xxxxxxxxx> > --- > diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh > index f61b40c..4e1f8ec 100755 > --- a/t/t0302-credential-store.sh > +++ b/t/t0302-credential-store.sh > @@ -6,4 +6,118 @@ test_description='credential-store tests' > > helper_test store > > +test_expect_success 'get: use xdg file if home file is unreadable' ' I meant to mention this earlier. Does this test need to be protected by the POSIXPERM prerequisite since it's using chmod? test_expect_success POSIXPERM 'get: ... unreadable' ' Otherwise, the test will likely fail on Windows. > + echo "https://home-user:home-pass@xxxxxxxxxxx" >"$HOME/.git-credentials" && > + chmod -r "$HOME/.git-credentials" && > + mkdir -p "$HOME/.config/git" && > + echo "https://xdg-user:xdg-pass@xxxxxxxxxxx" >"$HOME/.config/git/credentials" && > + check fill store <<-\EOF > + protocol=https > + host=example.com > + -- > + protocol=https > + host=example.com > + username=xdg-user > + password=xdg-pass > + -- > + EOF > +' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html