about Starter project;implementing log --size in the print_commit function.

[Shanti Swarup Tunga <b112041@xxxxxxxxxxxxx>]

I inserted a size variable of int type and calculated size in each
cases of print_commit(). The function is

static void print_commit(git_commit *commit)
{
    char buf[GIT_OID_HEXSZ + 1];
    int i, count;
    const git_signature *sig;
    const char *scan, *eol;
    int size=0;

    git_oid_tostr(buf, sizeof(buf), git_commit_id(commit));
    printf("commit %s\n", buf);

    if ((count = (int)git_commit_parentcount(commit)) > 1) {
        printf("Merge:");
        for (i = 0; i < count; ++i) {
            git_oid_tostr(buf, 8, git_commit_parent_id(commit, i));
            size=size+strlen(buf);
            printf(" %s", buf);
        }
        printf("\n");

    }

    if ((sig = git_commit_author(commit)) != NULL) {
        size=size+strlen(sig->name)+strlen(sig->email);
        printf("Author: %s <%s>\n", sig->name, sig->email);
        print_time(&sig->when, "Date:   ");
    }
    printf("\n");

    for (scan = git_commit_message(commit); scan && *scan; ) {
        for (eol = scan; *eol && *eol != '\n'; ++eol) /* find eol */;

        size=size+strlen(scan);
        printf("    %.*s\n", (int)(eol - scan), scan);
        scan = *eol ? eol + 1 : NULL;
    }
    printf("\n");
    printf("%d",size);
}




Will that approach is going to work for the following problem.?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html