Hi Johannes,
Johannes Schindelin wrote:
On Sat, 3 Mar 2007, Ramsay Jones wrote:
Note: set OLD_ICONV in your config.mak file on Cygwin.
Shouldn't you set it in Makefile instead?
Yes, well the first version of that patch did exactly that!
(which caused me to use "git commit --amend" for the first time.)
However, I changed my mind, in order to be consistent with
the NO_C99_FORMAT patch (2/6); I am assuming that at some point
newlib will update iconv() to the new prototype, and I would
have to remove OLD_ICONV from the Makefile again.
To be clear, the setting of both NO_C99_FORMAT and OLD_ICONV in
the config.mak file is determined by the capabilities (version)
of your compiler/library. (And is not just a Cygwin issue)
Having said that, I don't really mind if it is added to the Makefile.
All the best,
Ramsay Jones
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html