Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > I also tend to favor adding "failure" tests which are flipped to > "success" when appropriate, however, as this is an entirely new > feature, this approach may be unsuitable (and perhaps overkill). I can buy the "overkill", but not unsuitable. Even for new features, the tests should fail before and pass after. Otherwise, the tests are not testing the feature. Actually, this is a strong principle in test-driven development: don't write code unless you have a failing test. But I was just thinking out loudly, certainly not requesting a change. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html