On Thu, Mar 19, 2015 at 4:04 AM, Jeff King <peff@xxxxxxxx> wrote: > On Wed, Mar 18, 2015 at 02:58:15PM +0000, John Keeping wrote: > >> On Wed, Mar 18, 2015 at 09:41:59PM +0700, Duy Nguyen wrote: >> > On Wed, Mar 18, 2015 at 9:33 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: >> > > If not, I made some mistake in analyzing this and we'll start again. >> > >> > I did make one mistake, the first "gc" should have reduced the number >> > of loose objects to zero. Why didn't it.? I'll come back to this >> > tomorrow if nobody finds out first :) >> >> Most likely they are not referenced by anything but are younger than 2 >> weeks. >> >> I saw a similar issue with automatic gc triggering after every operation >> when I did something equivalent to: >> >> git add <lots of files> >> git commit >> git reset --hard HEAD^ >> >> which creates a log of unreachable objects which are not old enough to >> be pruned. > > Yes, this is almost certainly the problem. Though to be pedantic, the > command above will still have a reflog entry, so the objects will be > reachable (and packed). But there are other variants that don't leave > the objects reachable from even reflogs. > > I don't know if there is an easy way around this. Auto-gc's object count > is making the assumption that running the gc will reduce the number of > objects, but obviously it does not always do so. We could do a more > thorough check and find the number of actual packable and prune-able > objects. The "prune-able" part of that is easy; just omit objects from > the count that are newer than 2 weeks. But "packable" is expensive. You > would have to compute reachability by walking from the tips. That can > take tens of seconds on a large repo. Or we could count/estimate the number of loose objects again after repack/prune. Then we can maybe have a way to prevent the next gc that we know will not improve the situation anyway. One option is pack unreachable objects in the second pack. This would stop the next gc, but that would screw prune up because st_mtime info is gone.. Maybe we just save a file to tell gc to ignore the number of loose objects until after a specific date. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html