Re: git submodule: update=!command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 18, 2015 at 8:43 PM, Chris Packham <judge.packham@xxxxxxxxx> wrote:
> On Wed, Mar 18, 2015 at 10:05 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Ryan Lortie <desrt@xxxxxxxx> writes:
>>
>>> On Tue, Mar 17, 2015, at 16:49, Junio C Hamano wrote:
>>>> With more recent versions of Git, namely, the versions after
>>>> 30a52c1d (Merge branch 'ms/submodule-update-config-doc' into maint,
>>>> 2015-03-13), the documentation pages already have updated
>>>> descriptions around this area.
>>>
>>> sigh.
>>>
>>> That's what I get for forgetting to type 'git pull' before writing a
>>> patch.
>>>
>>> Sorry for the noise!
>>
>> Nothing to apologise or sigh about.  You re-confirmed that the old
>> documentation was lacking, which led to an earlier discussion which
>> in turn led to Michal to update the documentation.  If you check the
>> output from
>>
>>     git diff 30a52c1d^ 30a52c1d
>>
>> and find it appropriately address the problem you originally had,
>> that would be wonderful, and if you can suggest further improvement,
>> that is equally good.
>
> I think 30a52c1d could be improved with the following snippet from Ryans patch.
>
> "For security reasons, this feature is not supported from the
> `.gitmodules` file"
>
> Or something along those lines.

Which is actually down the bottom if I take the time to read the whole diff.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]