On Mon, Mar 16, 2015 at 4:16 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Duy Nguyen <pclouds@xxxxxxxxx> writes: > >> Exactly. We would need to sort and stuff later on, so true filenames >> are preserved in util->item. A cleaner way is perhaps carry all >> metadata in item->util and item->string remains true filename, then do >> all the formatting, coloring for all strings just before displaying. > > I guess we are then in agreement with my review comment on [04/16]. Yes. I'm redoing it. I will probably stop using string-list as well (it's inherited from the old code), just an array of struct. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html