This patch provides fixes for two minor memory leaks in the handle_alias function: 1. We allocate memory for alias_argv with the xmalloc function call, after run_command_v_opt function will be executed we no need in this variable anymore, so let's free it. 2. Memory allocated for alias_string variable in the alias_lookup function, need to free it. Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx> --- git.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/git.c b/git.c index 086fac1..501e5bd 100644 --- a/git.c +++ b/git.c @@ -252,6 +252,7 @@ static int handle_alias(int *argcp, const char ***argv) alias_argv[argc] = NULL; ret = run_command_v_opt(alias_argv, RUN_USING_SHELL); + free(alias_argv); if (ret >= 0) /* normal exit */ exit(ret); @@ -259,6 +260,7 @@ static int handle_alias(int *argcp, const char ***argv) alias_command, alias_string + 1); } count = split_cmdline(alias_string, &new_argv); + free(alias_string); if (count < 0) die("Bad alias.%s string: %s", alias_command, split_cmdline_strerror(count)); -- 2.3.3.469.g69a3822.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html