On Fri, Mar 13, 2015 at 12:53 AM, Jeff King <peff@xxxxxxxx> wrote: > We use this to test http pushing with a restricted > commandline. Other scripts (like t5551, which does http > fetching) will want to use it, too. > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > As we discussed a while ago, this is the exact same code that > run_with_limited_stack uses in t7004. However, I think they are > conceptually two different things, and I could imagine a platform where > they have distinct implementations. So I did not refactor t7004 to make > use of this. Perhaps this commentary should be moved to the commit message so that the next person who notices that run_with_limited_stack() is the same will understand why it was left alone. > t/t5541-http-push-smart.sh | 6 ------ > t/test-lib.sh | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh > index d2c681e..1ecb588 100755 > --- a/t/t5541-http-push-smart.sh > +++ b/t/t5541-http-push-smart.sh > @@ -324,12 +324,6 @@ test_expect_success 'push into half-auth-complete requires password' ' > test_cmp expect actual > ' > > -run_with_limited_cmdline () { > - (ulimit -s 128 && "$@") > -} > - > -test_lazy_prereq CMDLINE_LIMIT 'run_with_limited_cmdline true' > - > test_expect_success CMDLINE_LIMIT 'push 2000 tags over http' ' > sha1=$(git rev-parse HEAD) && > test_seq 2000 | > diff --git a/t/test-lib.sh b/t/test-lib.sh > index 7dd4b4d..9914d3e 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -1062,3 +1062,9 @@ test_lazy_prereq UNZIP ' > "$GIT_UNZIP" -v > test $? -ne 127 > ' > + > +run_with_limited_cmdline () { > + (ulimit -s 128 && "$@") > +} > + > +test_lazy_prereq CMDLINE_LIMIT 'run_with_limited_cmdline true' > -- > 2.3.2.472.geadab3c -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html