Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
> ---
> builtin/list-files.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/builtin/list-files.c b/builtin/list-files.c
> index ac33f13..b99f2b7 100644
> --- a/builtin/list-files.c
> +++ b/builtin/list-files.c
> @@ -65,6 +65,8 @@ int cmd_list_files(int argc, const char **argv, const char *cmd_prefix)
> {
> struct string_list result = STRING_LIST_INIT_NODUP;
>
> + setenv(GIT_GLOB_PATHSPECS_ENVIRONMENT, "1", 0);
> +
> if (argc == 2 && !strcmp(argv[1], "-h"))
> usage_with_options(ls_usage, ls_options);
Yikes.
I do not have enough info at this step in the series to judge if it
is sensible to force the :(glob) interpretation as default, but is
it something we would want to do commonly to flip the default per
Git subcommand? If so, using the environment feels like a clunky
way to do that.
How about a two-patch clean-up before this step?
(1) remove the handling of literal_global and friends that peek
into various environment variables from prefix_pathspec(),
which is a function that is repeatedly called for each pathspec
element given from the command line, and move that logic to
parse_pathspec(); pass necessary information down to
prefix_pathspec() as parameter(s);
(2) allow parse_pathspec() so that the caller can say "the default,
when there is no environment variable given by the end user to
tell us otherwise, is to :(glob)".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html