On Tue, Mar 10, 2015 at 3:43 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>
>> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
>> ---
>> builtin/help.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/builtin/help.c b/builtin/help.c
>> index 6133fe4..a1f5a0a 100644
>> --- a/builtin/help.c
>> +++ b/builtin/help.c
>> @@ -456,7 +456,7 @@ static void list_common_guides_help(void)
>> int cmd_help(int argc, const char **argv, const char *prefix)
>> {
>> int nongit;
>> - const char *alias;
>> + char *alias;
>> enum help_format parsed_help_format;
>>
>> argc = parse_options(argc, argv, prefix, builtin_help_options,
>> @@ -499,6 +499,7 @@ int cmd_help(int argc, const char **argv, const char *prefix)
>> alias = alias_lookup(argv[0]);
>> if (alias && !is_git_command(argv[0])) {
>> printf_ln(_("`git %s' is aliased to `%s'"), argv[0], alias);
>> + free(alias);
>
> Hmph, does this memory belong to us, or are we peeking into the
> cached data in the config cache layer?
So alias_lookup(..) is a wrapper around git_config_string essentially
(some more git_config_functions are involved, but we eventually reach
git_config_string), where we have
*dest = xstrdup(value);
so I think we need to free that memory, as the config cache layer doesn't
care any more.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html