Re: [PATCH v3 2/2] Added tests for reset -

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 1:52 PM, Sudhanshu Shekhar
<sudshekhar02@xxxxxxxxx> wrote:
> On Tue, Mar 10, 2015 at 6:56 PM, Matthieu Moy
> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
>> Sudhanshu Shekhar <sudshekhar02@xxxxxxxxx> writes:
>>> +test_expect_success 'reset - in the presence of file named - with previous branch' '
>>> +     echo "Unstaged changes after reset:" >expect &&
>>> +     echo "M -" >>expect &&
>>> +     echo "M 1" >>expect &&
>>
>> Here and elsewhere: why not
>>
>>         cat >expect <<-EOF
>>         Unstaged changes after reset:
>>         M -
>>         M 1
>>
>> ?
> I was confused whether to use cat or echo. I thought using cat will
> disrupt the indentation as the EOF needs to be on a single line. This
> is why I chose echo. Please let me know your thoughts on this.

Here-docs are easier to compose and read than individual 'echo'
statements for multi-line content.

The '-' in front of EOF allows you to indent the entire body. Even
better, use -\EOF to signify that you don't expect any interpolation
to occur within the body.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]